[server/session] add missing rollback when freeing a db connection When we let go of a cnxset and give it back to the pool, we need to make sure it's not in the middle of a transaction. We got bitten by a migration where the connection used by admin's repo.connect was not rolled back before attempting the migration, causing a deadlock because it had a lock on a table. This could potentially also be an issue for e.g. hooks or looping tasks that didn't explicitly rollback before calling free_cnxset or moving out of a ensure_cnx_set block.

     1

/* -*- sql -*- 

     2

     3

   mysql specific registered procedures, 

     4

     5

*/

     6

     7

/* XXX limit_size version dealing with format as postgres version does.

     8

   XXX mysql doesn't support overloading, each function should have a different name

     9

    10

   NOTE: fulltext renamed since it cause a mysql name conflict

    11

 */

    12

    13

CREATE FUNCTION text_limit_size(vfulltext TEXT, maxsize INT)

    14

RETURNS TEXT

    15

NO SQL

    16

BEGIN

    17

    IF LENGTH(vfulltext) < maxsize THEN

    18

       RETURN vfulltext;

    19

    ELSE

    20

       RETURN SUBSTRING(vfulltext from 1 for maxsize) || '...';

    21

    END IF;

    22

END ;;