[server/session] add missing rollback when freeing a db connection When we let go of a cnxset and give it back to the pool, we need to make sure it's not in the middle of a transaction. We got bitten by a migration where the connection used by admin's repo.connect was not rolled back before attempting the migration, causing a deadlock because it had a lock on a table. This could potentially also be an issue for e.g. hooks or looping tasks that didn't explicitly rollback before calling free_cnxset or moving out of a ensure_cnx_set block.

     1

[MESSAGES CONTROL]

     2

disable-msg = C0301

     3

     4

[VARIABLES]

     5

# Enable / disable this checker

     6

enable-variables = yes

     7

additional-builtins = _, display_name

     8

     9

[BASIC]

    10

required-attributes=

    11

attr-rgx = (w|[a-z_][a-z0-9_]{2,30})

    12

variable-rgx = (w|[a-z_][a-z0-9_]{2,30})$

    13

argument-rgx = (w|[a-z_][a-z0-9_]{2,30})$

    14

    15

[TYPECHECK]

    16

generated-members=debug,info,notice,warning,error,critical,exception