[server/session] add missing rollback when freeing a db connection When we let go of a cnxset and give it back to the pool, we need to make sure it's not in the middle of a transaction. We got bitten by a migration where the connection used by admin's repo.connect was not rolled back before attempting the migration, causing a deadlock because it had a lock on a table. This could potentially also be an issue for e.g. hooks or looping tasks that didn't explicitly rollback before calling free_cnxset or moving out of a ensure_cnx_set block.

     1

for eschema in schema.entities():

     2

    if not (eschema.final or 'cw_source' in eschema.subjrels):

     3

        add_relation_definition(eschema.type, 'cw_source', 'CWSource', ask_confirm=False)

     4

     5

sql('INSERT INTO cw_source_relation(eid_from, eid_to) '

     6

    'SELECT e.eid,s.cw_eid FROM entities as e, cw_CWSource as s '

     7

    'WHERE s.cw_name=e.source AND NOT EXISTS(SELECT 1 FROM cw_source_relation WHERE eid_from=e.eid AND eid_to=s.cw_eid)')

     8

commit()