[ldapfeed] FIX: Unique Key violation when synchronizing with LDAPfeed What was happening ================== The bug appears when ldapfeed tries to insert a user while another user exists exists with a different source. Simple use case to reproduce: - create a local user in cubicweb (source=system) - sync with ldap - ldapfeed will stop complaining user already exists. Without next patch the test MUST fail with message: cubicweb/server/sources/native.py:714: UniqueTogetherError The ldapfeed is thus stopped ignoring any further ldap entries. The proposal ============ Prior to this patch, the insertion was trying to create all CWUser with the computed login from eeimporter.extid2eid (method process of DataFeedLDAPAdapter). When a CWUser existed with a different cw_source ("system" for user created with cubicweb for instance), it created a conflict. To avoid collisions, in the extentities_generator method a bypass was added at the insertion layer. Prior to insertion the absence of the computed login is checked on a list of all existing login from a different source. If collision is detected, we skip the ldap record. By short circuiting at the CWUser entity insertion level we also avoid to treat CWGroup and EmailAddress related to this user. Hence ensuring a behaviour that will not break existing instances. (conservative approach: faced with ambiguity better do nothing than guess). An error message is added stating explicitly the conflict.

     1

[MASTER]

     2

load-plugins=cubicweb.pylintext

     3

ignore=__pkginfo__

     4

     5

[MESSAGES CONTROL]

     6

disable = too-many-ancestors,too-many-instance-attributes,too-many-public-methods,

     7

      too-few-public-methods,too-many-arguments,import-error

     8

     9

[BASIC]

    10

function-rgx = [a-z_][a-z0-9_]{2,35}$

    11

good-names=w,_

    12

    13

[TYPECHECK]

    14

generated-members=debug,info,notice,warning,error,critical,exception

    15

    16

[CLASSES]

    17

exclude-protected=_cw,_cnx,

    18

      # namedtuple public API.

    19

      _asdict,_fields,_replace,_source,_make

    20

    21

    22

[FORMAT]

    23

max-line-length=100

    24

max-module-lines=2000