debian/cubicweb-ctl.install
author Rémi Cardona <remi.cardona@logilab.fr>
Mon, 21 Dec 2015 12:47:35 +0100
changeset 11017 3dfed980071c
parent 10559 5821ae654dfd
child 11832 e8be49ecb522
permissions -rw-r--r--
[devtools] Use super() in TestServerConfiguration.__init__() While cleaning up the use of init_config() in WSGIAppTC, I wondered why the method was trying to set the 'https_uiprops' and 'https_datadir_url' attributes on the config, when WebConfiguration's __init__ should be taking care of setting them. WSGIAppTC uses the default configuration - one that derives from ApptestConfiguration (noted as G below). The issue is that the class hierarchy of ApptestConfiguration includes TestServerConfiguration (C in the graph below) which calls ServerConfiguration's __init__ directly (B below). As B does not have an __init__ method, CubicWebConfiguration's __init__ is called directly (A below). This has the unintended consequence of preventing WebConfiguration's __init__ from being called. A / \ B D | | C E \ / F | G | ... A: cwconfig.CubicWebConfiguration B: server.serverconfig.ServerConfiguration C: devtools.TestServerConfiguration D: web.webconfig.WebConfiguration E: etwist.twconfig.WebConfigurationBase F: devtools.BaseApptestConfiguration G: devtools.ApptestConfiguration NB: unittest_wsgi wasn't really broken, as it's the only test in wsgi/test/, but I figured I might as well clean it up. Related to #9297611.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
9208
7ae95f48e2f0 [pkg] fix debian packaging (closes #3058542)
David Douard <david.douard@logilab.fr>
parents: 858
diff changeset
     1
usr/bin/cubicweb-ctl usr/bin/
10559
5821ae654dfd [pkg] various debian packaging fixes
Julien Cristau <julien.cristau@logilab.fr>
parents: 9208
diff changeset
     2
usr/lib/python2*/*-packages/cubicweb/cwctl.py
9208
7ae95f48e2f0 [pkg] fix debian packaging (closes #3058542)
David Douard <david.douard@logilab.fr>
parents: 858
diff changeset
     3
../cubicweb-ctl.bash_completion etc/bash_completion.d/cubicweb-ctl