Change hooks control (deny_all_hooks_but / allow_all_hooks_but) to be more predictable Prior to this, if one execute code like: with cnx.hooks.deny_all_hooks_but('metadata'): with cnx.hooks.deny_all_hooks_but(): # mycode 'metadata' hooks will be activated anyway in the inner block, which is rather unexpected (of course in real life you only see the latest hooks control statement, the former being higher in the call stack). This is due to the underlying usage of old `enable_hook_categories` / `disable_hook_categories` methods, which were introduced much before the now official context manager based API (with `cnx.[deny|all]_all_hooks_but(...)`). To move on, this patch drop the two legacy methods, rename and privatize related internal state on the connection (`hooks_mode` becomes `_hooks_mode`, `disabled_hook_cats` and `enabled_hook_cats` become `_hooks_categories`) and reimplement the `_hooks_control` context manager to simply update them. See the added unit test for details.

     1

"""Contains predicates used in Pyramid views.

     2

"""

     3

     4

     5

class MatchIsETypePredicate(object):

     6

    """A predicate that match if a given etype exist in schema.

     7

    """

     8

    def __init__(self, matchname, config):

     9

        self.matchname = matchname

    10

    11

    def text(self):

    12

        return 'match_is_etype = %s' % self.matchname

    13

    14

    phash = text

    15

    16

    def __call__(self, info, request):

    17

        return info['match'][self.matchname].lower() in \

    18

            request.registry['cubicweb.registry'].case_insensitive_etypes

    19

    20

    21

def includeme(config):

    22

    config.add_route_predicate('match_is_etype', MatchIsETypePredicate)