Change hooks control (deny_all_hooks_but / allow_all_hooks_but) to be more predictable Prior to this, if one execute code like: with cnx.hooks.deny_all_hooks_but('metadata'): with cnx.hooks.deny_all_hooks_but(): # mycode 'metadata' hooks will be activated anyway in the inner block, which is rather unexpected (of course in real life you only see the latest hooks control statement, the former being higher in the call stack). This is due to the underlying usage of old `enable_hook_categories` / `disable_hook_categories` methods, which were introduced much before the now official context manager based API (with `cnx.[deny|all]_all_hooks_but(...)`). To move on, this patch drop the two legacy methods, rename and privatize related internal state on the connection (`hooks_mode` becomes `_hooks_mode`, `disabled_hook_cats` and `enabled_hook_cats` become `_hooks_categories`) and reimplement the `_hooks_control` context manager to simply update them. See the added unit test for details.

     1

# copyright 2003-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.

     2

# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr

     3

#

     4

# This file is part of CubicWeb.

     5

#

     6

# CubicWeb is free software: you can redistribute it and/or modify it under the

     7

# terms of the GNU Lesser General Public License as published by the Free

     8

# Software Foundation, either version 2.1 of the License, or (at your option)

     9

# any later version.

    10

#

    11

# CubicWeb is distributed in the hope that it will be useful, but WITHOUT

    12

# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS

    13

# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more

    14

# details.

    15

#

    16

# You should have received a copy of the GNU Lesser General Public License along

    17

# with CubicWeb.  If not, see <http://www.gnu.org/licenses/>.