author | Sylvain Thénault <sylvain.thenault@logilab.fr> |
Wed, 09 Dec 2015 17:44:17 +0100 | |
changeset 11001 | 37c5c9b3b3bf |
parent 10969 | b4de8b1cc135 |
child 11033 | 63d860a14a17 |
permissions | -rw-r--r-- |
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
1 |
# copyright 2003-2013 LOGILAB S.A. (Paris, FRANCE), all rights reserved. |
5421
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
2 |
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
3 |
# |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
4 |
# This file is part of CubicWeb. |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
5 |
# |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
6 |
# CubicWeb is free software: you can redistribute it and/or modify it under the |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
7 |
# terms of the GNU Lesser General Public License as published by the Free |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
8 |
# Software Foundation, either version 2.1 of the License, or (at your option) |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
9 |
# any later version. |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
10 |
# |
5424
8ecbcbff9777
replace logilab-common by CubicWeb in disclaimer
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5421
diff
changeset
|
11 |
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT |
5421
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
12 |
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
13 |
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
14 |
# details. |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
15 |
# |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
16 |
# You should have received a copy of the GNU Lesser General Public License along |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
17 |
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>. |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
18 |
"""The edit controller, automatically handling entity form submitting""" |
0 | 19 |
|
20 |
__docformat__ = "restructuredtext en" |
|
1948 | 21 |
|
4932
dce5ebe5d598
add missing warn imports
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
22 |
from warnings import warn |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
23 |
from collections import defaultdict |
4932
dce5ebe5d598
add missing warn imports
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
24 |
|
10016
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
25 |
from datetime import datetime |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
26 |
|
10730
874ac29b515d
[py3k] unicode → six.text_type
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10669
diff
changeset
|
27 |
from six import text_type |
874ac29b515d
[py3k] unicode → six.text_type
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10669
diff
changeset
|
28 |
|
8034
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
29 |
from logilab.common.deprecation import deprecated |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
30 |
from logilab.common.graph import ordered_nodes |
8034
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
31 |
|
0 | 32 |
from rql.utils import rqlvar_maker |
33 |
||
10969 | 34 |
from cubicweb import _, Binary, ValidationError |
9256
697a8181ba30
remove 3.9 bw compat
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
9196
diff
changeset
|
35 |
from cubicweb.view import EntityAdapter |
8190
2a3c1b787688
[vreg] move base registry implementation to logilab.common. Closes #1916014
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8128
diff
changeset
|
36 |
from cubicweb.predicates import is_instance |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
37 |
from cubicweb.web import (INTERNAL_FIELD_VALUE, RequestError, NothingToEdit, |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
38 |
ProcessFormError) |
4387
4aacd6492ef4
reorganize code:
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4359
diff
changeset
|
39 |
from cubicweb.web.views import basecontrollers, autoform |
0 | 40 |
|
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
41 |
|
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
42 |
class IEditControlAdapter(EntityAdapter): |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
43 |
__regid__ = 'IEditControl' |
5877
0c7b7b76a84f
[selectors] provide a new, optimized, is_instance selector that should at some point replace implements (along with the adaptable selector)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5676
diff
changeset
|
44 |
__select__ = is_instance('Any') |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
45 |
|
8034
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
46 |
def __init__(self, _cw, **kwargs): |
8041
81794aa0c8b4
[edit controller] only display warning on specific adapters
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8034
diff
changeset
|
47 |
if self.__class__ is not IEditControlAdapter: |
81794aa0c8b4
[edit controller] only display warning on specific adapters
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8034
diff
changeset
|
48 |
warn('[3.14] IEditControlAdapter is deprecated, override EditController' |
81794aa0c8b4
[edit controller] only display warning on specific adapters
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8034
diff
changeset
|
49 |
' using match_edited_type or match_form_id selectors for example.', |
81794aa0c8b4
[edit controller] only display warning on specific adapters
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8034
diff
changeset
|
50 |
DeprecationWarning) |
8034
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
51 |
super(IEditControlAdapter, self).__init__(_cw, **kwargs) |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
52 |
|
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
53 |
def after_deletion_path(self): |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
54 |
"""return (path, parameters) which should be used as redirect |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
55 |
information when this entity is being deleted |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
56 |
""" |
5569
cb14af012a96
[adapters] refactoring fixes
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5557
diff
changeset
|
57 |
parent = self.entity.cw_adapt_to('IBreadCrumbs').parent_entity() |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
58 |
if parent is not None: |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
59 |
return parent.rest_path(), {} |
5569
cb14af012a96
[adapters] refactoring fixes
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5557
diff
changeset
|
60 |
return str(self.entity.e_schema).lower(), {} |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
61 |
|
8034
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
62 |
def pre_web_edit(self): |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
63 |
"""callback called by the web editcontroller when an entity will be |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
64 |
created/modified, to let a chance to do some entity specific stuff. |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
65 |
|
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
66 |
Do nothing by default. |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
67 |
""" |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
68 |
pass |
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
69 |
|
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
70 |
|
5038
90493551b1eb
[form] fix validation error handling
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4940
diff
changeset
|
71 |
def valerror_eid(eid): |
90493551b1eb
[form] fix validation error handling
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4940
diff
changeset
|
72 |
try: |
8748
f5027f8d2478
drop typed_eid() in favour of int() (closes #2742462)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8697
diff
changeset
|
73 |
return int(eid) |
5038
90493551b1eb
[form] fix validation error handling
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4940
diff
changeset
|
74 |
except (ValueError, TypeError): |
90493551b1eb
[form] fix validation error handling
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4940
diff
changeset
|
75 |
return eid |
0 | 76 |
|
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
77 |
class RqlQuery(object): |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
78 |
def __init__(self): |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
79 |
self.edited = [] |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
80 |
self.restrictions = [] |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
81 |
self.kwargs = {} |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
82 |
|
8827
0d81a474c0fe
[editcontroller] a small debugging help (closes #2518980)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8697
diff
changeset
|
83 |
def __repr__(self): |
0d81a474c0fe
[editcontroller] a small debugging help (closes #2518980)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8697
diff
changeset
|
84 |
return ('Query <edited=%r restrictions=%r kwargs=%r>' % ( |
0d81a474c0fe
[editcontroller] a small debugging help (closes #2518980)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8697
diff
changeset
|
85 |
self.edited, self.restrictions, self.kwargs)) |
0d81a474c0fe
[editcontroller] a small debugging help (closes #2518980)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8697
diff
changeset
|
86 |
|
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
87 |
def insert_query(self, etype): |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
88 |
if self.edited: |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
89 |
rql = 'INSERT %s X: %s' % (etype, ','.join(self.edited)) |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
90 |
else: |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
91 |
rql = 'INSERT %s X' % etype |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
92 |
if self.restrictions: |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
93 |
rql += ' WHERE %s' % ','.join(self.restrictions) |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
94 |
return rql |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
95 |
|
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
96 |
def update_query(self, eid): |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
97 |
varmaker = rqlvar_maker() |
10669
155c29e0ed1c
[py3k] use next builtin instead of next method
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10662
diff
changeset
|
98 |
var = next(varmaker) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
99 |
while var in self.kwargs: |
10669
155c29e0ed1c
[py3k] use next builtin instead of next method
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10662
diff
changeset
|
100 |
var = next(varmaker) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
101 |
rql = 'SET %s WHERE X eid %%(%s)s' % (','.join(self.edited), var) |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
102 |
if self.restrictions: |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
103 |
rql += ', %s' % ','.join(self.restrictions) |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
104 |
self.kwargs[var] = eid |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
105 |
return rql |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
106 |
|
9178
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
107 |
def set_attribute(self, attr, value): |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
108 |
self.kwargs[attr] = value |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
109 |
self.edited.append('X %s %%(%s)s' % (attr, attr)) |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
110 |
|
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
111 |
def set_inlined(self, relation, value): |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
112 |
self.kwargs[relation] = value |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
113 |
self.edited.append('X %s %s' % (relation, relation.upper())) |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
114 |
self.restrictions.append('%s eid %%(%s)s' % (relation.upper(), relation)) |
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
115 |
|
0 | 116 |
|
4387
4aacd6492ef4
reorganize code:
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4359
diff
changeset
|
117 |
class EditController(basecontrollers.ViewController): |
3377
dd9d292b6a6d
use __regid__ instead of id on appobject classes
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3369
diff
changeset
|
118 |
__regid__ = 'edit' |
0 | 119 |
|
2255
c346af0727ca
more generic way to detect json requests (not yet perfect though)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
120 |
def publish(self, rset=None): |
0 | 121 |
"""edit / create / copy / delete entity / relations""" |
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
122 |
for key in self._cw.form: |
0 | 123 |
# There should be 0 or 1 action |
124 |
if key.startswith('__action_'): |
|
125 |
cbname = key[1:] |
|
126 |
try: |
|
127 |
callback = getattr(self, cbname) |
|
128 |
except AttributeError: |
|
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
129 |
raise RequestError(self._cw._('invalid action %r' % key)) |
0 | 130 |
else: |
131 |
return callback() |
|
132 |
self._default_publish() |
|
133 |
self.reset() |
|
134 |
||
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
135 |
def _ordered_formparams(self): |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
136 |
""" Return form parameters dictionaries for each edited entity. |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
137 |
|
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
138 |
We ensure that entities can be created in this order accounting for |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
139 |
mandatory inlined relations. |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
140 |
""" |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
141 |
req = self._cw |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
142 |
graph = {} |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
143 |
get_rschema = self._cw.vreg.schema.rschema |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
144 |
# minparams = 2, because at least __type and eid are needed |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
145 |
values_by_eid = dict((eid, req.extract_entity_params(eid, minparams=2)) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
146 |
for eid in req.edited_eids()) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
147 |
# iterate over all the edited entities |
10662
10942ed172de
[py3k] dict.iteritems → dict.items
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10385
diff
changeset
|
148 |
for eid, values in values_by_eid.items(): |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
149 |
# add eid to the dependency graph |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
150 |
graph.setdefault(eid, set()) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
151 |
# search entity's edited fields for mandatory inlined relation |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
152 |
for param in values['_cw_entity_fields'].split(','): |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
153 |
try: |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
154 |
rtype, role = param.split('-') |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
155 |
except ValueError: |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
156 |
# e.g. param='__type' |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
157 |
continue |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
158 |
rschema = get_rschema(rtype) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
159 |
if rschema.inlined: |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
160 |
for target in rschema.targets(values['__type'], role): |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
161 |
rdef = rschema.role_rdef(values['__type'], target, role) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
162 |
# if cardinality is 1 and if the target entity is being |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
163 |
# simultaneously edited, the current entity must be |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
164 |
# created before the target one |
9439
549c999d06d2
[editcontroller] fix cardinality computation (closes #3120495)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
9256
diff
changeset
|
165 |
if rdef.cardinality[0 if role == 'subject' else 1] == '1': |
10385
cb3a48780615
fix EditController._ordered_formparams method in case some mandatory relation isn't specified
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
10016
diff
changeset
|
166 |
# use .get since param may be unspecified (though it will usually lead |
cb3a48780615
fix EditController._ordered_formparams method in case some mandatory relation isn't specified
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
10016
diff
changeset
|
167 |
# to a validation error later) |
cb3a48780615
fix EditController._ordered_formparams method in case some mandatory relation isn't specified
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
10016
diff
changeset
|
168 |
target_eid = values.get(param) |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
169 |
if target_eid in values_by_eid: |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
170 |
# add dependency from the target entity to the |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
171 |
# current one |
9196
13461cb8ff40
[editcontrollers] Account for role in the ordering of entities (Complements #3031719)
Denis Laxalde <denis.laxalde@logilab.fr>
parents:
9179
diff
changeset
|
172 |
if role == 'object': |
13461cb8ff40
[editcontrollers] Account for role in the ordering of entities (Complements #3031719)
Denis Laxalde <denis.laxalde@logilab.fr>
parents:
9179
diff
changeset
|
173 |
graph.setdefault(target_eid, set()).add(eid) |
13461cb8ff40
[editcontrollers] Account for role in the ordering of entities (Complements #3031719)
Denis Laxalde <denis.laxalde@logilab.fr>
parents:
9179
diff
changeset
|
174 |
else: |
13461cb8ff40
[editcontrollers] Account for role in the ordering of entities (Complements #3031719)
Denis Laxalde <denis.laxalde@logilab.fr>
parents:
9179
diff
changeset
|
175 |
graph.setdefault(eid, set()).add(target_eid) |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
176 |
break |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
177 |
for eid in reversed(ordered_nodes(graph)): |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
178 |
yield values_by_eid[eid] |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
179 |
|
0 | 180 |
def _default_publish(self): |
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
181 |
req = self._cw |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
182 |
self.errors = [] |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
183 |
self.relations_rql = [] |
0 | 184 |
form = req.form |
3921
4f24b6ef3da9
edit controller now informs server side about its main eid through transaction data
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3689
diff
changeset
|
185 |
# so we're able to know the main entity from the repository side |
4f24b6ef3da9
edit controller now informs server side about its main eid through transaction data
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3689
diff
changeset
|
186 |
if '__maineid' in form: |
9774
b7b71be569cf
deprecate get/set_shared_data API
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
9635
diff
changeset
|
187 |
req.transaction_data['__maineid'] = form['__maineid'] |
0 | 188 |
# no specific action, generic edition |
189 |
self._to_create = req.data['eidmap'] = {} |
|
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
190 |
# those two data variables are used to handle relation from/to entities |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
191 |
# which doesn't exist at time where the entity is edited and that |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
192 |
# deserves special treatment |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
193 |
req.data['pending_inlined'] = defaultdict(set) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
194 |
req.data['pending_others'] = set() |
6400
21468682f688
restore vital block of code (gone in 6384:89d5b339ebdd)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
6384
diff
changeset
|
195 |
try: |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
196 |
for formparams in self._ordered_formparams(): |
6400
21468682f688
restore vital block of code (gone in 6384:89d5b339ebdd)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
6384
diff
changeset
|
197 |
eid = self.edit_entity(formparams) |
8695
358d8bed9626
[toward-py3k] rewrite to "except AnException as exc:" (part of #2711624)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8556
diff
changeset
|
198 |
except (RequestError, NothingToEdit) as ex: |
6400
21468682f688
restore vital block of code (gone in 6384:89d5b339ebdd)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
6384
diff
changeset
|
199 |
if '__linkto' in req.form and 'eid' in req.form: |
21468682f688
restore vital block of code (gone in 6384:89d5b339ebdd)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
6384
diff
changeset
|
200 |
self.execute_linkto() |
21468682f688
restore vital block of code (gone in 6384:89d5b339ebdd)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
6384
diff
changeset
|
201 |
elif not ('__delete' in req.form or '__insert' in req.form): |
10730
874ac29b515d
[py3k] unicode → six.text_type
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10669
diff
changeset
|
202 |
raise ValidationError(None, {None: text_type(ex)}) |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
203 |
# all pending inlined relations to newly created entities have been |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
204 |
# treated now (pop to ensure there are no attempt to add new ones) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
205 |
pending_inlined = req.data.pop('pending_inlined') |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
206 |
assert not pending_inlined, pending_inlined |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
207 |
# handle all other remaining relations now |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
208 |
for form_, field in req.data.pop('pending_others'): |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
209 |
self.handle_formfield(form_, field) |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
210 |
# then execute rql to set all relations |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
211 |
for querydef in self.relations_rql: |
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
212 |
self._cw.execute(*querydef) |
0 | 213 |
# XXX this processes *all* pending operations of *all* entities |
8697
574bb05e40a4
[toward py3k] rewrite has_key() (part of #2711624)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8695
diff
changeset
|
214 |
if '__delete' in req.form: |
4277
35cd057339b2
turn all the stuff used to handle 'generic relations' in forms into proper
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4252
diff
changeset
|
215 |
todelete = req.list_form_param('__delete', req.form, pop=True) |
35cd057339b2
turn all the stuff used to handle 'generic relations' in forms into proper
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4252
diff
changeset
|
216 |
if todelete: |
4387
4aacd6492ef4
reorganize code:
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4359
diff
changeset
|
217 |
autoform.delete_relations(self._cw, todelete) |
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
218 |
self._cw.remove_pending_operations() |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
219 |
if self.errors: |
10730
874ac29b515d
[py3k] unicode → six.text_type
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10669
diff
changeset
|
220 |
errors = dict((f.name, text_type(ex)) for f, ex in self.errors) |
5038
90493551b1eb
[form] fix validation error handling
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4940
diff
changeset
|
221 |
raise ValidationError(valerror_eid(form.get('__maineid')), errors) |
1753 | 222 |
|
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
223 |
def _insert_entity(self, etype, eid, rqlquery): |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
224 |
rql = rqlquery.insert_query(etype) |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
225 |
try: |
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
226 |
entity = self._cw.execute(rql, rqlquery.kwargs).get_entity(0, 0) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
227 |
neweid = entity.eid |
8695
358d8bed9626
[toward-py3k] rewrite to "except AnException as exc:" (part of #2711624)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8556
diff
changeset
|
228 |
except ValidationError as ex: |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
229 |
self._to_create[eid] = ex.entity |
8128
0a927fe4541b
[controllers] deprecate JSonController and implement AjaxController / ajax-func registry (closes #2110265)
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
8041
diff
changeset
|
230 |
if self._cw.ajax_request: # XXX (syt) why? |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
231 |
ex.entity = eid |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
232 |
raise |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
233 |
self._to_create[eid] = neweid |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
234 |
return neweid |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
235 |
|
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
236 |
def _update_entity(self, eid, rqlquery): |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
237 |
self._cw.execute(rqlquery.update_query(eid), rqlquery.kwargs) |
1753 | 238 |
|
0 | 239 |
def edit_entity(self, formparams, multiple=False): |
240 |
"""edit / create / copy an entity and return its eid""" |
|
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
241 |
req = self._cw |
0 | 242 |
etype = formparams['__type'] |
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
243 |
entity = req.vreg['etypes'].etype_class(etype)(req) |
6029
aac5dba278c7
[editcontroller] turn eid into an int if possible, avoiding pbs. further down (case: preview cube)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
5877
diff
changeset
|
244 |
entity.eid = valerror_eid(formparams['eid']) |
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
245 |
is_main_entity = req.form.get('__maineid') == formparams['eid'] |
8034
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
246 |
# let a chance to do some entity specific stuff |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
247 |
entity.cw_adapt_to('IEditControl').pre_web_edit() |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
248 |
# create a rql query from parameters |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
249 |
rqlquery = RqlQuery() |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
250 |
# process inlined relations at the same time as attributes |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
251 |
# this will generate less rql queries and might be useful in |
b07d61090706
replace adapter by simple selector to ease edit controller overloading; fixes #2042349
Florent Cayré <florent.cayre@gmail.com>
parents:
7990
diff
changeset
|
252 |
# a few dark corners |
7182
09454384fff8
[edit controller] fix subform formid in EditController (would need further improvement)
Florent Cayré <florent.cayre@gmail.com>
parents:
6864
diff
changeset
|
253 |
if is_main_entity: |
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
254 |
formid = req.form.get('__form_id', 'edition') |
7182
09454384fff8
[edit controller] fix subform formid in EditController (would need further improvement)
Florent Cayré <florent.cayre@gmail.com>
parents:
6864
diff
changeset
|
255 |
else: |
09454384fff8
[edit controller] fix subform formid in EditController (would need further improvement)
Florent Cayré <florent.cayre@gmail.com>
parents:
6864
diff
changeset
|
256 |
# XXX inlined forms formid should be saved in a different formparams entry |
09454384fff8
[edit controller] fix subform formid in EditController (would need further improvement)
Florent Cayré <florent.cayre@gmail.com>
parents:
6864
diff
changeset
|
257 |
# inbetween, use cubicweb standard formid for inlined forms |
09454384fff8
[edit controller] fix subform formid in EditController (would need further improvement)
Florent Cayré <florent.cayre@gmail.com>
parents:
6864
diff
changeset
|
258 |
formid = 'edition' |
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
259 |
form = req.vreg['forms'].select(formid, req, entity=entity) |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
260 |
eid = form.actual_eid(entity.eid) |
9520
78702b55c089
Drop 3.13 incomplete backward compat in edit controller.
Florent Cayré <florent.cayre@logilab.fr>
parents:
9439
diff
changeset
|
261 |
editedfields = formparams['_cw_entity_fields'] |
7584
e1881933f366
[form, controller] closes #1787233: form should provide a method to process posted content
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7182
diff
changeset
|
262 |
form.formvalues = {} # init fields value cache |
e1881933f366
[form, controller] closes #1787233: form should provide a method to process posted content
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7182
diff
changeset
|
263 |
for field in form.iter_modified_fields(editedfields, entity): |
e1881933f366
[form, controller] closes #1787233: form should provide a method to process posted content
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7182
diff
changeset
|
264 |
self.handle_formfield(form, field, rqlquery) |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
265 |
# if there are some inlined field which were waiting for this entity's |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
266 |
# creation, add relevant data to the rqlquery |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
267 |
for form_, field in req.data['pending_inlined'].pop(entity.eid, ()): |
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
268 |
rqlquery.set_inlined(field.name, form_.edited_entity.eid) |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
269 |
if self.errors: |
10730
874ac29b515d
[py3k] unicode → six.text_type
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10669
diff
changeset
|
270 |
errors = dict((f.role_name(), text_type(ex)) for f, ex in self.errors) |
5038
90493551b1eb
[form] fix validation error handling
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4940
diff
changeset
|
271 |
raise ValidationError(valerror_eid(entity.eid), errors) |
0 | 272 |
if eid is None: # creation or copy |
9590
048d6de92b63
Make EditController edit_entity method always return an eid
Denis Laxalde <denis.laxalde@logilab.fr>
parents:
9439
diff
changeset
|
273 |
entity.eid = eid = self._insert_entity(etype, formparams['eid'], rqlquery) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
274 |
elif rqlquery.edited: # edition of an existant entity |
10016
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
275 |
self.check_concurrent_edition(formparams, eid) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
276 |
self._update_entity(eid, rqlquery) |
3386
ab797c5374b7
[editcontroller] rename is_edited variable into is_main_entity to make things clearer
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3384
diff
changeset
|
277 |
if is_main_entity: |
0 | 278 |
self.notify_edited(entity) |
8697
574bb05e40a4
[toward py3k] rewrite has_key() (part of #2711624)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8695
diff
changeset
|
279 |
if '__delete' in formparams: |
4277
35cd057339b2
turn all the stuff used to handle 'generic relations' in forms into proper
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4252
diff
changeset
|
280 |
# XXX deprecate? |
9177
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
281 |
todelete = req.list_form_param('__delete', formparams, pop=True) |
5236d0e4c598
[editcontroller] req=self._cw makes things easier to read
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
8848
diff
changeset
|
282 |
autoform.delete_relations(req, todelete) |
8697
574bb05e40a4
[toward py3k] rewrite has_key() (part of #2711624)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8695
diff
changeset
|
283 |
if '__cloned_eid' in formparams: |
8748
f5027f8d2478
drop typed_eid() in favour of int() (closes #2742462)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8697
diff
changeset
|
284 |
entity.copy_relations(int(formparams['__cloned_eid'])) |
3386
ab797c5374b7
[editcontroller] rename is_edited variable into is_main_entity to make things clearer
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3384
diff
changeset
|
285 |
if is_main_entity: # only execute linkto for the main entity |
4073
03681ba6da0b
cw 3.6 api update
Sandrine Ribeau <sandrine.ribeau@logilab.fr>
parents:
4053
diff
changeset
|
286 |
self.execute_linkto(entity.eid) |
0 | 287 |
return eid |
288 |
||
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
289 |
def handle_formfield(self, form, field, rqlquery=None): |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
290 |
eschema = form.edited_entity.e_schema |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
291 |
try: |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
292 |
for field, value in field.process_posted(form): |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
293 |
if not ( |
4053
7cc66b1d9183
more api update
Sandrine Ribeau <sandrine.ribeau@logilab.fr>
parents:
4045
diff
changeset
|
294 |
(field.role == 'subject' and field.name in eschema.subjrels) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
295 |
or |
4053
7cc66b1d9183
more api update
Sandrine Ribeau <sandrine.ribeau@logilab.fr>
parents:
4045
diff
changeset
|
296 |
(field.role == 'object' and field.name in eschema.objrels)): |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
297 |
continue |
4045
f4a52abb6f4f
cw 3.6 api update
Sandrine Ribeau <sandrine.ribeau@logilab.fr>
parents:
4007
diff
changeset
|
298 |
rschema = self._cw.vreg.schema.rschema(field.name) |
4053
7cc66b1d9183
more api update
Sandrine Ribeau <sandrine.ribeau@logilab.fr>
parents:
4045
diff
changeset
|
299 |
if rschema.final: |
9178
b5762ac9a82e
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9177
diff
changeset
|
300 |
rqlquery.set_attribute(field.name, value) |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
301 |
else: |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
302 |
if form.edited_entity.has_eid(): |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
303 |
origvalues = set(entity.eid for entity in form.edited_entity.related(field.name, field.role, entities=True)) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
304 |
else: |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
305 |
origvalues = set() |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
306 |
if value is None or value == origvalues: |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
307 |
continue # not edited / not modified / to do later |
4249
222fbf826604
don't call handle_inlined_relation where we're not on the relation'subject
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4231
diff
changeset
|
308 |
if rschema.inlined and rqlquery is not None and field.role == 'subject': |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
309 |
self.handle_inlined_relation(form, field, value, origvalues, rqlquery) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
310 |
elif form.edited_entity.has_eid(): |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
311 |
self.handle_relation(form, field, value, origvalues) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
312 |
else: |
9179
570208f74a84
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
9178
diff
changeset
|
313 |
form._cw.data['pending_others'].add( (form, field) ) |
8695
358d8bed9626
[toward-py3k] rewrite to "except AnException as exc:" (part of #2711624)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8556
diff
changeset
|
314 |
except ProcessFormError as exc: |
3387
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
315 |
self.errors.append((field, exc)) |
a357d4147eee
[forms] work-in-progress, big editcontroller refactoring: let fields/widgets process posted data
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3386
diff
changeset
|
316 |
|
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
317 |
def handle_inlined_relation(self, form, field, values, origvalues, rqlquery): |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
318 |
"""handle edition for the (rschema, x) relation of the given entity |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
319 |
""" |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
320 |
if values: |
10669
155c29e0ed1c
[py3k] use next builtin instead of next method
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10662
diff
changeset
|
321 |
rqlquery.set_inlined(field.name, next(iter(values))) |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
322 |
elif form.edited_entity.has_eid(): |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
323 |
self.handle_relation(form, field, values, origvalues) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
324 |
|
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
325 |
def handle_relation(self, form, field, values, origvalues): |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
326 |
"""handle edition for the (rschema, x) relation of the given entity |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
327 |
""" |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
328 |
etype = form.edited_entity.e_schema |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
329 |
rschema = self._cw.vreg.schema.rschema(field.name) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
330 |
if field.role == 'subject': |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
331 |
desttype = rschema.objects(etype)[0] |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
332 |
card = rschema.rdef(etype, desttype).cardinality[0] |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
333 |
subjvar, objvar = 'X', 'Y' |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
334 |
else: |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
335 |
desttype = rschema.subjects(etype)[0] |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
336 |
card = rschema.rdef(desttype, etype).cardinality[1] |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
337 |
subjvar, objvar = 'Y', 'X' |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
338 |
eid = form.edited_entity.eid |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
339 |
if field.role == 'object' or not rschema.inlined or not values: |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
340 |
# this is not an inlined relation or no values specified, |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
341 |
# explicty remove relations |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
342 |
rql = 'DELETE %s %s %s WHERE X eid %%(x)s, Y eid %%(y)s' % ( |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
343 |
subjvar, rschema, objvar) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
344 |
for reid in origvalues.difference(values): |
5174
78438ad513ca
#759035: Automate addition of eid cachekey in RQL analysis
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
345 |
self.relations_rql.append((rql, {'x': eid, 'y': reid})) |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
346 |
seteids = values.difference(origvalues) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
347 |
if seteids: |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
348 |
rql = 'SET %s %s %s WHERE X eid %%(x)s, Y eid %%(y)s' % ( |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
349 |
subjvar, rschema, objvar) |
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
350 |
for reid in seteids: |
5174
78438ad513ca
#759035: Automate addition of eid cachekey in RQL analysis
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5061
diff
changeset
|
351 |
self.relations_rql.append((rql, {'x': eid, 'y': reid})) |
4171
f1b9f0ed1253
make new editcontroller works, based on a _cw_edited_fields hidden input
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4160
diff
changeset
|
352 |
|
4883
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
353 |
def delete_entities(self, eidtypes): |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
354 |
"""delete entities from the repository""" |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
355 |
redirect_info = set() |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
356 |
eidtypes = tuple(eidtypes) |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
357 |
for eid, etype in eidtypes: |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
358 |
entity = self._cw.entity_from_eid(eid, etype) |
5556
9ab2b4c74baf
[entity] introduce a new 'adapters' registry
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5426
diff
changeset
|
359 |
path, params = entity.cw_adapt_to('IEditControl').after_deletion_path() |
10662
10942ed172de
[py3k] dict.iteritems → dict.items
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10385
diff
changeset
|
360 |
redirect_info.add( (path, tuple(params.items())) ) |
5557
1a534c596bff
[entity] continue cleanup of Entity/AnyEntity namespace
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5556
diff
changeset
|
361 |
entity.cw_delete() |
4883
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
362 |
if len(redirect_info) > 1: |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
363 |
# In the face of ambiguity, refuse the temptation to guess. |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
364 |
self._after_deletion_path = 'view', () |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
365 |
else: |
10669
155c29e0ed1c
[py3k] use next builtin instead of next method
Rémi Cardona <remi.cardona@logilab.fr>
parents:
10662
diff
changeset
|
366 |
self._after_deletion_path = next(iter(redirect_info)) |
4883
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
367 |
if len(eidtypes) > 1: |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
368 |
self._cw.set_message(self._cw._('entities deleted')) |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
369 |
else: |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
370 |
self._cw.set_message(self._cw._('entity deleted')) |
11899d28337f
[web] cleanup: move delete_entities to the edit controller
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4665
diff
changeset
|
371 |
|
10016
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
372 |
|
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
373 |
def check_concurrent_edition(self, formparams, eid): |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
374 |
req = self._cw |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
375 |
try: |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
376 |
form_ts = datetime.fromtimestamp(float(formparams['__form_generation_time'])) |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
377 |
except KeyError: |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
378 |
# Backward and tests compatibility : if no timestamp consider edition OK |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
379 |
return |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
380 |
if req.execute("Any X WHERE X modification_date > %(fts)s, X eid %(eid)s", |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
381 |
{'eid': eid, 'fts': form_ts}): |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
382 |
# We only mark the message for translation but the actual |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
383 |
# translation will be handled by the Validation mechanism... |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
384 |
msg = _("Entity %(eid)s has changed since you started to edit it." |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
385 |
" Reload the page and reapply your changes.") |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
386 |
# ... this is why we pass the formats' dict as a third argument. |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
387 |
raise ValidationError(eid, {None: msg}, {'eid' : eid}) |
984505da8b89
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Anthony Truchet <anthony.truchet@logilab.fr>
parents:
9774
diff
changeset
|
388 |
|
0 | 389 |
def _action_apply(self): |
390 |
self._default_publish() |
|
391 |
self.reset() |
|
1753 | 392 |
|
0 | 393 |
def _action_delete(self): |
3451
6b46d73823f5
[api] work in progress, use __regid__, cw_*, etc.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3396
diff
changeset
|
394 |
self.delete_entities(self._cw.edited_eids(withtype=True)) |
0 | 395 |
return self.reset() |